Diego Novillo
2003-02-03 17:27:30 UTC
This merge needed a few tweaks to allow bootstrapping with
-Werror. The warnings are mostly caused by the gimplifier.
There are two types:
- Use of uninitialized variables. Given the following code
fragment:
j = 3;
if (j < 5 || (i = 3) > 0)
j = i++;
The gimplifier will produce the following transformation:
j = 3;
T.1 = j <= 4;
if (T.1 == 0)
{
i = 3;
T.1 = i > 0
};
if (T.1)
{
i.2 = i;
i = i + 1;
j = i.2
};
This trips the warning because we still don't have enough
analysis implemented to determine that 'i' is never used
uninitialized. The two if's generated by the gimplifier are
mutually exclusive. We could probably change the gimplifier to
not do this expansion, but it's easier to fix the code for now.
Initializing inside an if() is not very common, anyway.
- The second type of warning comes from the expanders for
va_start. In tree.c:build_stmt, we have
build_stmt VPARAMS ((enum tree_code code, ...))
{
...
VA_OPEN (p, code);
...
}
build_stmt (code)
{
...
code.162 = (unsigned int)code;
__builtin_va_start (p.161, code.162);
...
}
The builtin expander issues the warning 'second parameter of
`va_start' not last named argument'. Jason thinks that this
warning should be moved up into the front end. I agree with
that.
I added -Wno-error to the files that trigger this warning.
Bootstrapped and tested on x86.
2003-02-03 Diego Novillo <***@redhat.com>
Fix warnings to allow bootstrapping with -Werror.
* Makefile.in (c-semantics.o-warn): Add -Wno-error.
(emit-rtl.o-warn): Likewise.
(profile.o-warn): Likewise.
(tree.o-warn): Likewise.
(OBJS): Remove simple-break-elim.o and simple-goto-elim.o.
* c-pretty-print.c (print_function_decl): Remove unused function.
* bitmap.c (bitmap_last_set_bit): Initialize variable 'word'.
* c-typeck.c (build_binary_op): Initialize variable 'type'.
* combine.c (combine_simplify_rtx): Initialize variable 'reversed'.
(make_compound_operation): Initialize variable 'i'.
* dwarf2out.c (dwarf2out_finish): Initialize variable 'context'.
* expr.c (store_constructor): Initialize variables 'lo', 'hi',
'startb' and 'endb'.
(expand_expr): Initialize variable 'op0'.
* fold-const.c (fold): Initialize variable 'tem'.
* profile.c (branch_prob): Initialize variable 'prev_file_name'.
* reload.c (find_equiv_reg): Initialize variables 'valtry and
'valueno'.
* rtlanal.c (get_jump_table_offset): Initialize variable 'set'.
* ssa-ccp.c (ssa_const_prop): Fix sign mismatch warning.
* varasm.c (output_constant_def): Initialize variable 'defstr'.
* gimplify.c (simplify_expr): Initialize variables
'saved_input_filename' and 'saved_lineno'.
(simplify_compound_lval): Initialize variable 'code'.
* tree-alias-ander.c (pta_bottom): De-ansify.
(andersen_cleanup): Remove unused variables.
(andersen_heap_assign): Mark argument lhs ATTRIBUTE_UNUSED.
(pta_bottom): Remove unused function.
(pta_get_ptsize): Remove unused function.
cp/
2003-02-03 Diego Novillo <***@redhat.com>
* parser.c (cp_parser_asm_definition): Call finish_asm_stmt with
'volatile_p' directly.
* typeck.c (build_binary_op): Initialize variable 'type'.
* Make-lang.in (cp/tree.o-warn): Add -Wno-error.
java/
2003-02-03 Diego Novillo <***@redhat.com>
* parse.y (qualify_ambiguous_name): Initialize variable 'decl'.
-Werror. The warnings are mostly caused by the gimplifier.
There are two types:
- Use of uninitialized variables. Given the following code
fragment:
j = 3;
if (j < 5 || (i = 3) > 0)
j = i++;
The gimplifier will produce the following transformation:
j = 3;
T.1 = j <= 4;
if (T.1 == 0)
{
i = 3;
T.1 = i > 0
};
if (T.1)
{
i.2 = i;
i = i + 1;
j = i.2
};
This trips the warning because we still don't have enough
analysis implemented to determine that 'i' is never used
uninitialized. The two if's generated by the gimplifier are
mutually exclusive. We could probably change the gimplifier to
not do this expansion, but it's easier to fix the code for now.
Initializing inside an if() is not very common, anyway.
- The second type of warning comes from the expanders for
va_start. In tree.c:build_stmt, we have
build_stmt VPARAMS ((enum tree_code code, ...))
{
...
VA_OPEN (p, code);
...
}
build_stmt (code)
{
...
code.162 = (unsigned int)code;
__builtin_va_start (p.161, code.162);
...
}
The builtin expander issues the warning 'second parameter of
`va_start' not last named argument'. Jason thinks that this
warning should be moved up into the front end. I agree with
that.
I added -Wno-error to the files that trigger this warning.
Bootstrapped and tested on x86.
2003-02-03 Diego Novillo <***@redhat.com>
Fix warnings to allow bootstrapping with -Werror.
* Makefile.in (c-semantics.o-warn): Add -Wno-error.
(emit-rtl.o-warn): Likewise.
(profile.o-warn): Likewise.
(tree.o-warn): Likewise.
(OBJS): Remove simple-break-elim.o and simple-goto-elim.o.
* c-pretty-print.c (print_function_decl): Remove unused function.
* bitmap.c (bitmap_last_set_bit): Initialize variable 'word'.
* c-typeck.c (build_binary_op): Initialize variable 'type'.
* combine.c (combine_simplify_rtx): Initialize variable 'reversed'.
(make_compound_operation): Initialize variable 'i'.
* dwarf2out.c (dwarf2out_finish): Initialize variable 'context'.
* expr.c (store_constructor): Initialize variables 'lo', 'hi',
'startb' and 'endb'.
(expand_expr): Initialize variable 'op0'.
* fold-const.c (fold): Initialize variable 'tem'.
* profile.c (branch_prob): Initialize variable 'prev_file_name'.
* reload.c (find_equiv_reg): Initialize variables 'valtry and
'valueno'.
* rtlanal.c (get_jump_table_offset): Initialize variable 'set'.
* ssa-ccp.c (ssa_const_prop): Fix sign mismatch warning.
* varasm.c (output_constant_def): Initialize variable 'defstr'.
* gimplify.c (simplify_expr): Initialize variables
'saved_input_filename' and 'saved_lineno'.
(simplify_compound_lval): Initialize variable 'code'.
* tree-alias-ander.c (pta_bottom): De-ansify.
(andersen_cleanup): Remove unused variables.
(andersen_heap_assign): Mark argument lhs ATTRIBUTE_UNUSED.
(pta_bottom): Remove unused function.
(pta_get_ptsize): Remove unused function.
cp/
2003-02-03 Diego Novillo <***@redhat.com>
* parser.c (cp_parser_asm_definition): Call finish_asm_stmt with
'volatile_p' directly.
* typeck.c (build_binary_op): Initialize variable 'type'.
* Make-lang.in (cp/tree.o-warn): Add -Wno-error.
java/
2003-02-03 Diego Novillo <***@redhat.com>
* parse.y (qualify_ambiguous_name): Initialize variable 'decl'.